Remove unnecessary wildcards from LogPlugin and convert warnings to errors.
#12046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 22, 2024
alice-i-cecile
added
C-Code-Quality
james7132
approved these changes
Feb 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
… errors. (bevyengine#12046) # Objective Improve code quality and prevent bugs. ## Solution I removed the unnecessary wildcards from `<LogPlugin as Plugin>::build`. I also changed the warnings that would occur if the subscriber/logger was already set into errors.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
… errors. (bevyengine#12046) # Objective Improve code quality and prevent bugs. ## Solution I removed the unnecessary wildcards from `<LogPlugin as Plugin>::build`. I also changed the warnings that would occur if the subscriber/logger was already set into errors.
mockersf
pushed a commit
that referenced
this pull request
Feb 27, 2024
… errors. (#12046) # Objective Improve code quality and prevent bugs. ## Solution I removed the unnecessary wildcards from `<LogPlugin as Plugin>::build`. I also changed the warnings that would occur if the subscriber/logger was already set into errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Improve code quality and prevent bugs.
Solution
I removed the unnecessary wildcards from
<LogPlugin as Plugin>::build.I also changed the warnings that would occur if the subscriber/logger was already set into errors.