Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "fluent" methods to modify color channels. #12099

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Adding "fluent" methods to modify color channels. #12099

merged 1 commit into from
Feb 24, 2024

Conversation

viridia
Copy link
Contributor

@viridia viridia commented Feb 24, 2024

Fixes #12075

alice-i-cecile
alice-i-cecile approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add with_alpha to the alpha trait?

@viridia
Copy link
Contributor Author

viridia commented Feb 24, 2024

Do we want to add with_alpha to the alpha trait?

It's already there.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 24, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Feb 24, 2024
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 24, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 24, 2024
Merged via the queue into bevyengine:main with commit 10aef14 Feb 24, 2024
27 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@viridia @msvbg
Adding "fluent" methods to modify color channels. (bevyengine#12099)
dcaa2cb 
Fixes bevyengine#12075
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
@viridia @msvbg
Adding "fluent" methods to modify color channels. (bevyengine#12099)
975e7c2 
Fixes bevyengine#12075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@afonsolage afonsolage afonsolage approved these changes

@bushrat011899 bushrat011899 Awaiting requested review from bushrat011899

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

bevy_color: Add fluent methods to color types.
4 participants
@viridia @afonsolage @james7132 @alice-i-cecile