-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a prelude for bevy_color, and add it to bevy_internal #12158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be entries in the root workspace Cargo.toml
or is this meant as a follow-up.
Good catch! Added; please take a look to verify that I did this correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bevy_render = ["bevy_internal/bevy_render", "bevy_color"]
You added a new feature but didn't update the readme. Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking even more enabling on features in the root, such as bevy_ui and bevy_sprite possibly.
You added a new feature but didn't update the readme. Please run |
I think this is it :) Technically it was already enabled transitively via |
Objective
As we start to migrate to
bevy_color
in earnest (#12056), we should make it visible to Bevy users, and usable in examples.Solution
bevy_color
: I've only excluded the rarely usedColorRange
type and the testing-focused color distance module. I definitely think that some color spaces are less useful than others to end users, but at the same time the types used there are very unlikely to conflict with user-facing types.bevy_color
tobevy_internal
as an optional crate.bevy_color
's prelude as part ofbevy::prelude
.