Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from
LegacyColor
tobevy_color::Color
#12163Migrate from
LegacyColor
tobevy_color::Color
#12163Changes from 5 commits
b684a2a
138e26c
fa8ad85
21de265
e00b6bd
c07ec86
d0dedbd
9d1f0d5
3829efd
ba58dc9
8bc6c4f
8e8d237
1df0713
1b46fd1
0cfe96f
c6806fa
2ae656c
0621f62
5d8212e
fe75eac
a6b8fb4
00616e2
80cb407
b7598cd
edd6988
d88b2fa
58c2eab
c2f52b0
1fb2f55
a094530
0dd2ba4
6b50ac6
948c1ee
6d2848e
ca5f22f
fd6616f
6a03503
66833d4
07500da
86614a9
5e52c49
3d7f8d2
76567a6
2072eee
4f3115d
d2a8e12
c06d915
8181762
cf8c4c7
075600b
1503719
13584c7
502f9d6
246e65a
03fdefc
ced8cd4
c7fd5e3
d400acb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to do some performance testing to confirm, but we probably need to go back over the various
From
implementations an annotate them with#[inline]
. I'm not sure how good the Rust compiler is at inlining these tiny functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed. I want to do perf testing towards the end of this process.