Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12255 Updating TargetCamera on multi camera scenes not allowing layout to be calculated #12268

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Fix #12255 Updating TargetCamera on multi camera scenes not allowing layout to be calculated #12268

merged 7 commits into from
Mar 4, 2024

Commits on Mar 3, 2024

  1. Add negative test for bevyengine#12255 

    Check to make sure the layout is getting calculated when TargetCamera is being updated on a node.
    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    76426f6 View commit details
    Browse the repository at this point in the history

  2. Fix for 12255 

    Make sure the children are being cleaned up and maintain taffy references to camera nodes
    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    71c028e View commit details
    Browse the repository at this point in the history

  3. Track camera taffy nodes separately

    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    538dd38 View commit details
    Browse the repository at this point in the history

  4. Satisfy clippy error

    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    e6e2042 View commit details
    Browse the repository at this point in the history

  5. Add test that ensures despawning cameras remove their respective taff… 

    …y nodes
    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    91a1c20 View commit details
    Browse the repository at this point in the history

  6. Fix casing on UiLayoutSystemRemovedComponentParam struct

    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    bf0bc66 View commit details
    Browse the repository at this point in the history

  7. Merge bevy_ecs imports

    @StrikeForceZero
    StrikeForceZero committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    b4b14a8 View commit details
    Browse the repository at this point in the history