Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreateWindowParams type and create_windows system public #12428

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

umut-sahin
Copy link
Contributor

Objective

To have a user level workaround for #12237.

Solution

Workaround to the problem is described in: #12237 (comment)

Changelog

Changed

  • CreateWindowParams type and create_windows system from bevy_winit is now public, which allows library authors and game developers to manually trigger window creation when needed.

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

…_winit` public for manual window creation
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 12, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 12, 2024
Merged via the queue into bevyengine:main with commit 78c754c Mar 12, 2024
28 checks passed
@alice-i-cecile alice-i-cecile added this to the 0.13.1 milestone Mar 14, 2024
mockersf pushed a commit that referenced this pull request Mar 15, 2024
…2428)

# Objective

To have a user level workaround for #12237.

## Solution

Workaround to the problem is described in:
#12237 (comment)

## Changelog

### Changed

- `CreateWindowParams` type and `create_windows` system from
`bevy_winit` is now public, which allows library authors and game
developers to manually trigger window creation when needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants