-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reflect for BinaryHeap #12503
add reflect for BinaryHeap #12503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a shame not to have the list-like behavior fully reflected, but it's fine to do this incrementally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI, there's a few errors and likely formatting that needs to be addressed.
I think it was erroring because I was still representing BinaryHeap as ReflectKind::List even though I could not implement reflect::List. I switched it to just use ReflectKind::Value. Although I'm not too sure how it works to add other bounds? I couldn't figure out how to add |
Those can only be applied if you require that |
Objective
I wanted to have reflection for BinaryHeap for a personal project.
I'm running into some issues:
reflect::List
? It is possible to implementFromReflect
without it. Would the type beStruct
then?