Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect default in some types on bevy_render #12580

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Reflect default in some types on bevy_render #12580

merged 5 commits into from
Mar 19, 2024

Conversation

pablo-lua
Copy link
Contributor

Objective

  • Many types in bevy_render doesn't reflect Default even if it could.

Solution

  • Reflect it.

@pablo-lua pablo-lua added A-Rendering Drawing game state to the screen A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 19, 2024
@pablo-lua
Copy link
Contributor Author

pablo-lua commented Mar 19, 2024 •
edited
Loading

Sorry for the many useless commits, I did something wrong in my local fork and thats hauting me for days.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 19, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 19, 2024
Merged via the queue into bevyengine:main with commit 40f82b8 Mar 19, 2024
31 checks passed
@pablo-lua pablo-lua deleted the reflect_default_on_render branch March 19, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablo-lua @james7132 @alice-i-cecile