Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always spawn fps_overlay on top of everything #12586

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Always spawn fps_overlay on top of everything #12586

merged 2 commits into from
Mar 20, 2024

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Mar 20, 2024 •
edited
Loading

Objective

  • Currently the fps_overlay affects any other ui node spawned. This should not happen

Solution

  • Use position absolute and a ZIndex of i32::MAX - 32
  • I also modified the example a little bit to center it correctly. It only worked previously because the overlay was pushing it down. I also took the opportunity to simplify the text spawning code a little bit.

@IceSentry IceSentry added A-Dev-Tools Tools used to debug Bevy applications. C-Bug An unexpected or incorrect behavior labels Mar 20, 2024
@IceSentry IceSentry mentioned this pull request Mar 20, 2024
Merged
@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 20, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 20, 2024
Merged via the queue into bevyengine:main with commit 4d0d070 Mar 20, 2024
27 checks passed
@IceSentry IceSentry deleted the fps_overlay_absolute_ui branch March 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiqo15 matiqo15 matiqo15 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@afonsolage afonsolage afonsolage approved these changes

@bushrat011899 bushrat011899 Awaiting requested review from bushrat011899

Assignees
No one assigned
Labels
A-Dev-Tools Tools used to debug Bevy applications. C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IceSentry @afonsolage @alice-i-cecile @matiqo15