Fix unhandled null characters in Android logs #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
O-Android
Kanabenki
reviewed
Mar 27, 2024
BD103
suggested changes
Mar 27, 2024
BD103
approved these changes
Mar 28, 2024
Kanabenki
approved these changes
Mar 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
matiqo15
approved these changes
Mar 28, 2024
matiqo15
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mockersf
pushed a commit
that referenced
this pull request
Apr 1, 2024
# Objective Fix #12728. Fix unsoundnesss from unhandled null characters in Android logs. ## Solution Use `CString` instead of using formatted Strings. Properly document the safety invariants of the FFI call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #12728. Fix unsoundnesss from unhandled null characters in Android logs.
Solution
Use
CStringinstead of using formatted Strings. Properly document the safety invariants of the FFI call.