Clean up WinitWindows::remove_window #12749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiqo15
added
A-Windowing
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
matiqo15
approved these changes
Mar 28, 2024
mockersf
approved these changes
Mar 28, 2024
|
can't think of a scenario where the info of "that window used to exist" is needed and that couldn't be handled by the user themselves |
mockersf
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
WinitWindows::remove_window.Migration Guide
WinitWindows::get_window_entitynow returnsNoneafter a window is closed, instead of a dead entity.Comments
The comment this PR replaces was added in #3575. Since
get_window_entitynow returns anEntityinstead of aWindowId, this no longer seems useful. Note thatget_window_entityis only used here, immediately followed by a warning if the entity returned doesn't exist.