Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torus benchmark #12781

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Torus benchmark #12781

merged 7 commits into from
Mar 29, 2024

Conversation

gibletfeets
Copy link
Contributor

Objective

  • Primitive meshing is suboptimal
  • Improve primitive meshing

Solution

  • Add primitive meshing benchmark
  • Allows measuring future improvements

First of a few PRs to refactor and improve primitive meshing.

@gibletfeets
Copy link
Contributor Author

benchmark
Result of current code benchmark on my system.

@matiqo15 matiqo15 added C-Feature A new feature, making something new possible C-Benchmarks Stress tests and benchmarks used to measure how fast things are A-Rendering Drawing game state to the screen labels Mar 29, 2024
@alice-i-cecile
Copy link
Member

I'd be happy to merge this benchmark first, and then move forward with improvements going forward.

It might make sense to group all of the shape meshing benchmarks together into a single file, but I'll defer to you.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 29, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 29, 2024
Merged via the queue into bevyengine:main with commit 622f9a3 Mar 29, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlv24 atlv24 atlv24 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibletfeets @alice-i-cecile @atlv24 @matiqo15