Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused nightly toolchain environmental variable #13037

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Remove unused nightly toolchain environmental variable #13037

merged 1 commit into from
Apr 19, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Apr 19, 2024

Objective

  • Many of our CI workflows contain a NIGHTLY_TOOLCHAIN environmental variable.
  • This specifies which nightly to use. If there is a bug in one of the nightlies, we can pin the toolchain to be an earlier version.
  • Both the daily and weekly workflows do not use the nightly compiler, but still have a NIGHTLY_TOOLCHAIN variable.

Solution

  • Delete the unused variable.

@BD103 BD103 added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels Apr 19, 2024
@james7132 james7132 added this pull request to the merge queue Apr 19, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 19, 2024
Merged via the queue into bevyengine:main with commit e9fb82a Apr 19, 2024
31 checks passed
@BD103 BD103 deleted the rm-nightly-var branch April 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BD103 @james7132 @alice-i-cecile