Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump async-task #13062

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Bump async-task #13062

merged 1 commit into from
Apr 22, 2024

Conversation

Zeophlite
Copy link
Contributor

Bumps async-task to 4.7.0 , note this is what Cargo.lock has as well. Building as a dependency gives the following:

   Compiling async-channel v1.8.0
   Compiling futures-lite v1.12.0
error[E0432]: unresolved import `async_task::Builder`
  --> /Users/daniel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-executor-1.8.0/src/lib.rs:46:18
   |
46 | use async_task::{Builder, Runnable};
   |                  ^^^^^^^ no `Builder` in the root
   |
   = help: consider importing this struct instead:
           std::thread::Builder

For more information about this error, try `rustc --explain E0432`.
error: could not compile `async-executor` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

With this change, builds correctly

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@BD103 BD103 added C-Dependencies A change to the crates that Bevy depends on A-Tasks Tools for parallel and async work P-Compile-Failure A failure to compile Bevy apps labels Apr 22, 2024
@BD103
Copy link
Member

BD103 commented Apr 22, 2024

I did a little testing. cargo c -p bevy_tasks fails with async-task = "=4.3.0", but succeeds with "=4.4.0". This PR technically bumps the version past where it needs to be to fix the bug, but I don't think that's a problem.

@BD103 BD103 requested a review from james7132 April 22, 2024 15:52
@james7132 james7132 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into bevyengine:main with commit 279e89b Apr 22, 2024
35 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
# Objective
Follow up to #13062. As of async-executor 1.11, the crate reexports
FallibleTask, which is the only reason bevy_tasks has a direct
dependency on async-task. This should avoid the two dependencies getting
out of sync in the future and causing spurious compilation failures.

## Solution
Bump async-executor to 1.11, use the reexport, remove the dependency on
async-task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Dependencies A change to the crates that Bevy depends on P-Compile-Failure A failure to compile Bevy apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants