Use ptr::from_ref and ptr::addr_eq in macro
#13081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both versions are equivalent (and likely compile the same). Both take advantage of early returns, known as "short-circuiting" when using the `&&` operator. Fun fact: `&&` short circuiting is one of the reasons this operator is not overloadable.
BD103
force-pushed
the
The-Office-Assistant-is-a-discontinued-intelligent-user-interface-for-Microsoft-Office
branch
from
810a7d7
to
500936b
Compare
BD103
added
A-ECS
james7132
approved these changes
Apr 24, 2024
BD103
deleted the
The-Office-Assistant-is-a-discontinued-intelligent-user-interface-for-Microsoft-Office
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
ptr::from_refwhen possible, because it prevents you from accidentally changing the mutability as well as its type.ptr::addr_eqwhen comparing two pointers, ignoring pointer metadata.