Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #13083

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: fix some comments #13083

merged 1 commit into from
Apr 25, 2024

Conversation

findmyhappy
Copy link
Contributor

@findmyhappy findmyhappy commented Apr 24, 2024 •
edited by alice-i-cecile
Loading

Objective

remove repetitive words

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

atlv24
atlv24 reviewed Apr 24, 2024
View reviewed changes
crates/bevy_pbr/src/render/parallax_mapping.wgsl Outdated Show resolved Hide resolved
crates/bevy_pbr/src/light/mod.rs Outdated Show resolved Hide resolved
soqb
soqb approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@soqb soqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for one grammar issue.

examples/app/logs.rs Outdated Show resolved Hide resolved
@findmyhappy
chore: fix some comments
a3f2ad5 
Signed-off-by: findmyhappy <[email protected]>
@findmyhappy findmyhappy changed the title chore: remove repetitive words chore: fix some comments Apr 24, 2024
@NthTensor NthTensor added C-Docs An addition or correction to our documentation A-Cross-Cutting Impacts the entire engine labels Apr 24, 2024
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 24, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 25, 2024
Merged via the queue into bevyengine:main with commit 36a3e53 Apr 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soqb soqb soqb approved these changes

@atlv24 atlv24 atlv24 approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@findmyhappy @james7132 @atlv24 @soqb @alice-i-cecile @NthTensor @pablo-lua