Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version field for non-publish crates and update descriptions #13100

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Apr 25, 2024

Objective

  • The version field in Cargo.toml is optional for crates not published on https://crates.io.
  • We have several publish = false tools in this repository that still have a version field, even when it's not useful.

Solution

  • Remove the version field for all crates where publish = false.
  • Update the description on a few crates and remove extra newlines as well.

And update the description on certain crates.
@BD103 BD103 added the A-Cross-Cutting Impacts the entire engine label Apr 25, 2024
@JMS55 JMS55 requested a review from mockersf April 25, 2024 17:04
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 25, 2024
@mockersf mockersf added this pull request to the merge queue Apr 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2024
@mockersf mockersf added this pull request to the merge queue Apr 26, 2024
Merged via the queue into bevyengine:main with commit 9ee02e8 Apr 26, 2024
31 checks passed
@BD103 BD103 deleted the rm-version branch April 26, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants