Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bevy_ui/layout] Make fields private in UiSurface #13359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[bevy_ui/layout] Make fields private in UiSurface #13359

wants to merge 4 commits into from
+1,000 −202

Commits on May 19, 2024

  1. bevyengine#12803 Changes (squashed) 

    Apply rustfmt
Move test_initialization next to other tests
Add doc comment to is_root_node_pair_valid
Move helper methods into the single test case where they are used
Add tests for helper methods
Remove trait helpers to reduce complexity of tests
Mark specific test functions as unreachable
Move ui_surface test only methods into mod tests as trait
Fix tests after rebase
Add tests for bevy_ui/layout/ui_surface
Widen type for parameter children in UiSurface::update_children
Add missing asserts and Debug fields in UiSurface from bevyengine#12268 and bevyengine#12698
    @StrikeForceZero
    StrikeForceZero committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b699e81 View commit details
    Browse the repository at this point in the history

  2. bevyengine#12804 changed Update internal mappings (squashed) 

    Move assertion above panic triggering line
Remove demotion logic to simplify scope
Remove potentially duplicated context update loop
Remove duplicated ContentSize removal handler
Restore assertion in ui tracking tests
Remove promotion test
Satisfy linter
Update test
Remove promotion helper
Apply rustfmt
Fix documentation
Add missing back ticks in doc comment
Underscore unused variables
Rebase fixes
Add regression test for recursive despawn on ui nodes
Apply rustfmt in bevy_ui/layout/debug
Remove message from unreachable!
Add/update documentation for UiSurface
Make missing root_node_data in compute_camera_layout an error
Fix promote_ui_node, add a test, and set to only be in cfg(test)
Update documentation
Use replace_camera_association to reduce redundant code
Use mark_root_node_as_orphaned
Add explicit taffy node counts to tests
Add test for promoting normal ui nodes into root nodes
Add support demoting root nodes into normal ui nodes
Expand tests to cover different methods of despawn
Remove user_root_node field in favor of using entity_to_taffy
Replace is_root_node_data_valid helper with has_valid_root_node_data
Implement updated map structure in UiSurface
Deprecate user_root_node in RootNodeData
Extract default viewport style into inline fn
Rename camera_id to camera_entity
    @StrikeForceZero
    StrikeForceZero committed May 19, 2024
    Configuration menu
    Copy the full SHA
    90afc38 View commit details
    Browse the repository at this point in the history

  3. Make UiSurface fields private

    @StrikeForceZero
    StrikeForceZero committed May 19, 2024
    Configuration menu
    Copy the full SHA
    73459f5 View commit details
    Browse the repository at this point in the history

  4. Move debug print into UiSurface to access private fields

    @StrikeForceZero
    StrikeForceZero committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8b3f47c View commit details
    Browse the repository at this point in the history