Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic uniform buffer in post processing example #13540

Merged
merged 1 commit into from
Jun 14, 2024

Commits on May 27, 2024

  1. Use dynamic uniform buffer for post process settings

    While learning about shaders and pipelines, I found this example
    to be misleading; it wasn't clear to me how the node knew what the correct
    "instance" of `PostProcessSettings` we should send to the GPU (as
    the combination of `ExtractComponentPlugin` and `UniformComponentPlugin`
    extracts + sends _all_ of our `PostProcessSetting` components).
    
    While the example in its current state is _correct_, I believe that fact
    that it's intended to showcase a per camera post processing effect
    warrants a dynamic uniform buffer (even though in the context of this
    example we have only one camera, and therefore no adverse behaviour).
    jgayfer committed May 27, 2024
    Configuration menu
    Copy the full SHA
    925ade1 View commit details
    Browse the repository at this point in the history