Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about missing StatesPlugin when installing states #13877

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Warn about missing StatesPlugin when installing states #13877

merged 2 commits into from
Jun 16, 2024

Conversation

MiniaczQ
Copy link
Contributor

Objective

Solution

  • Confirm that the StatesPlugin is installed when trying to add states.
  • Skipped for state scoped entities, since those will warn about missing states.

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 16, 2024
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 16, 2024
alice-i-cecile
alice-i-cecile approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I think that's a clean solution. Much better than docs!

benfrankel
benfrankel suggested changes Jun 16, 2024
View reviewed changes
crates/bevy_state/src/app.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 16, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 16, 2024
Merged via the queue into bevyengine:main with commit 90894a1 Jun 16, 2024
28 checks passed
mockersf pushed a commit that referenced this pull request Jun 19, 2024
@MiniaczQ @mockersf
Warn about missing StatesPlugin when installing states (#13877)
6cf04c2 
# Objective

- Fixes #13874

## Solution

- Confirm that the `StatesPlugin` is installed when trying to add
states.
- Skipped for state scoped entities, since those will warn about missing
states.
@MiniaczQ MiniaczQ deleted the check-states-plugin branch September 7, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfrankel benfrankel benfrankel approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

[Bug?] State is not updated when manually updating App
3 participants
@MiniaczQ @alice-i-cecile @benfrankel