Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update observer archetype flags for sparse components #13886

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Update observer archetype flags for sparse components #13886

merged 2 commits into from
Jun 17, 2024

Conversation

james-j-obrien
Copy link
Contributor

Objective

Solution

  • Update the flags correctly on archetype creation

Testing

  • Added observer_order_insert_remove_sparse to catch regressions.

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 17, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 17, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 17, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 17, 2024
Merged via the queue into bevyengine:main with commit 335dcf9 Jun 17, 2024
32 checks passed
mockersf pushed a commit that referenced this pull request Jun 19, 2024
@james-j-obrien @mockersf
Update observer archetype flags for sparse components (#13886)
5d5e67f 
# Objective

- Fixes #13885 

## Solution

- Update the flags correctly on archetype creation

## Testing

- Added `observer_order_insert_remove_sparse` to catch regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cBournhonesque cBournhonesque cBournhonesque approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

Observers don't trigger for Sparse components
3 participants
@james-j-obrien @alice-i-cecile @cBournhonesque