Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply window scale to window size when creating it #13967

Merged
merged 1 commit into from
Jun 21, 2024
Merged

apply window scale to window size when creating it #13967

merged 1 commit into from
Jun 21, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jun 21, 2024 •
edited
Loading

Objective

Solution

  • Apply the window scale to its size when creating it

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in labels Jun 21, 2024
@mockersf mockersf added this to the 0.14 milestone Jun 21, 2024
tychedelia
tychedelia approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 21, 2024
Merged via the queue into bevyengine:main with commit 841df15 Jun 21, 2024
31 checks passed
mockersf added a commit that referenced this pull request Jun 21, 2024
@mockersf
apply window scale to window size when creating it (#13967)
8af12c8 
# Objective

- Fixes #13702
- When creating a new window, its scale was changed to match the one
returned by winit, but its size was not which resulted in an incorrect
size until the event with the correct size was received, at least 1
frame later

## Solution

- Apply the window scale to its size when creating it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychedelia tychedelia tychedelia approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

weird startup scaling issues on macOS after winit 0.30
3 participants
@mockersf @alice-i-cecile @tychedelia