Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give non mesh things their own bin #14025

Closed
wants to merge 1 commit into from
Closed

give non mesh things their own bin #14025

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • If an entity doesn't have a mesh instance, make up an binned index for it

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jun 25, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jun 25, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 26, 2024
@pcwalton
Copy link
Contributor

#14029 is my version of this, which solves it in a different way and adds a test.

@alice-i-cecile
Copy link
Member

Closing in favor of pcwalton's version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMS55 JMS55 JMS55 approved these changes

@pcwalton pcwalton Awaiting requested review from pcwalton

@djeedai djeedai Awaiting requested review from djeedai

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

Can't upgrade to 0.14, impossible to render AlphaMask3d phase items without mesh
4 participants
@mockersf @pcwalton @alice-i-cecile @JMS55