Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix examples color_grading and mobile after BackgroundColor changes #14033

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix examples color_grading and mobile after BackgroundColor changes #14033

merged 2 commits into from
Jun 26, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jun 26, 2024 •
edited
Loading

Objective

Solution

  • Change it in the examples

@mockersf mockersf added the C-Examples An addition or correction to our examples label Jun 26, 2024
@mockersf mockersf added this to the 0.14 milestone Jun 26, 2024
@mockersf mockersf changed the title fix example color_grading after BackgroundColor changes fix examples color_grading and mobile after BackgroundColor changes Jun 26, 2024
@mockersf mockersf force-pushed the fix-color_grading-background-color-use branch from e1339fa to 24f16dc Compare June 26, 2024 06:10
benfrankel
benfrankel reviewed Jun 26, 2024
View reviewed changes
examples/mobile/src/lib.rs
..default()
},
BackgroundColor(Color::WHITE),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this ButtonBundle have a background_color: Color::WHITE.into() now? Or is the background meant to be transparent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done by the button_handler system

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 26, 2024
@alice-i-cecile
Copy link
Member

Thanks for catching these!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 26, 2024
Merged via the queue into bevyengine:main with commit ee63cf4 Jun 26, 2024
28 checks passed
mockersf added a commit that referenced this pull request Jun 26, 2024
@mockersf
fix examples color_grading and mobile after BackgroundColor changes (#…
e65e4be 
…14033)

# Objective

- #14017 changed how `UiImage` and `BackgroundColor` work
- one change was missed in example `color_grading`, another in the
mobile example

## Solution

- Change it in the examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfrankel benfrankel benfrankel approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @benfrankel