Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example showcase: keep the order of the shaders imported #14035

Merged
merged 2 commits into from
Jun 26, 2024
Merged

example showcase: keep the order of the shaders imported #14035

merged 2 commits into from
Jun 26, 2024

Conversation

mockersf
Copy link
Member

Objective

  • After Shader code paths #13908, shaders imported are collected
  • this is done with a hashset, so order is random between executions

Solution

  • Don't use a hashset, and keep the order they were found in the example

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples labels Jun 26, 2024
@mockersf mockersf added this to the 0.14 milestone Jun 26, 2024
janhohenheim
janhohenheim approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 26, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 26, 2024
Merged via the queue into bevyengine:main with commit f757fe8 Jun 26, 2024
31 checks passed
mockersf added a commit that referenced this pull request Jun 26, 2024
@mockersf
example showcase: keep the order of the shaders imported (#14035)
27aa9d2 
# Objective

- After #13908, shaders imported are collected
- this is done with a hashset, so order is random between executions

## Solution

- Don't use a hashset, and keep the order they were found in the example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @janhohenheim