Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add entity to error message #14163

Merged
merged 1 commit into from
Jul 8, 2024
Merged

add entity to error message #14163

merged 1 commit into from
Jul 8, 2024

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Jul 5, 2024

Objective

  • There was a new warning added about having an unstyled child in the ui hierarchy. Debugging the new error is pretty hard without any info about which entity is.

Solution

  • Add the entity id to the warning.
// Before
2024-07-05T19:40:59.904014Z  WARN bevy_ui::layout::ui_surface: Unstyled child in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.

//After
2024-07-05T19:40:59.904014Z  WARN bevy_ui::layout::ui_surface: Unstyled child `3v1` in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.

Changelog

  • add entity id to ui surface warning

@mnmaita mnmaita added the C-Usability A targeted quality-of-life change that makes Bevy easier to use label Jul 5, 2024
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Diagnostics Logging, crash handling, error reporting and performance analysis X-Uncontroversial This work is generally agreed upon labels Jul 5, 2024
@janhohenheim janhohenheim added this to the 0.14.1 milestone Jul 5, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit 91dd7e6 Jul 8, 2024
33 checks passed
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@hymm @mockersf
add entity to error message (#14163)
c6b80c5 
# Objective

- There was a new warning added about having an unstyled child in the ui
hierarchy. Debugging the new error is pretty hard without any info about
which entity is.

## Solution

- Add the entity id to the warning.

```text
// Before
2024-07-05T19:40:59.904014Z  WARN bevy_ui::layout::ui_surface: Unstyled child in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.

//After
2024-07-05T19:40:59.904014Z  WARN bevy_ui::layout::ui_surface: Unstyled child `3v1` in a UI entity hierarchy. You are using an entity without UI components as a child of an entity with UI components, results may be unexpected.
```

## Changelog

- add entity id to ui surface warning
@hymm hymm deleted the add-entity-to-ui-warning branch August 12, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnmaita mnmaita mnmaita approved these changes

@MiniaczQ MiniaczQ MiniaczQ approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
5 participants
@hymm @janhohenheim @MiniaczQ @mnmaita @alice-i-cecile