Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize unnecessary normalizations for Transform::local_{xyz} #14171

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Optimize unnecessary normalizations for Transform::local_{xyz} #14171

merged 3 commits into from
Jul 8, 2024

Conversation

janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Jul 5, 2024 •
edited
Loading

Note that GlobalTransform already does it like this for right, left, etc. so I didn't have to touch that one

@janhohenheim
Optimize unnecessary normalizations for Transform
bc4a31e 
Note that `GlobalTransform` already does it like this
@janhohenheim
Use old comments
8b8eec8
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy C-Performance A change motivated by improving speed, memory usage or compile times A-Math Fundamental domain-agnostic mathematical operations S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 5, 2024
@janhohenheim janhohenheim added this to the 0.14.1 milestone Jul 5, 2024
@janhohenheim janhohenheim changed the title Optimize unnecessary normalizations for Transform Optimize unnecessary normalizations for Transform::local_{xyz} Jul 5, 2024
@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit df80b99 Jul 8, 2024
27 checks passed
@janhohenheim janhohenheim deleted the patch-1 branch July 8, 2024 01:42
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@janhohenheim @mockersf
Optimize unnecessary normalizations for Transform::local_{xyz} (#14171
e941264 
)

Note that `GlobalTransform` already does it like this for `right`,
`left`, etc. so I didn't have to touch that one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiniaczQ MiniaczQ MiniaczQ approved these changes

@cBournhonesque cBournhonesque cBournhonesque approved these changes

@Jondolf Jondolf Awaiting requested review from Jondolf

@NthTensor NthTensor Awaiting requested review from NthTensor

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
4 participants
@janhohenheim @cBournhonesque @MiniaczQ @alice-i-cecile