Fix missing paths in ECS SystemParam derive macro #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Nice catch! |
|
/rebase |
cart
force-pushed
the
fix/ecs-macro-systemparam
branch
from
a371dc8
to
cff828d
Compare
Closed
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate. Co-authored-by: Piotr Balcer <[email protected]>
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2021
This is an updated version of #1434 PR. I've encountered this macro problem while trying to use @woubuc's bevy-event-set crate. Co-authored-by: Piotr Balcer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SystemParamderive macro had some missing path scopes, which lead toSystemParamnot correctly getting resolved in some situations.