Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single keyframe animations. #14344

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix single keyframe animations. #14344

merged 1 commit into from
Jul 22, 2024

Conversation

yrns
Copy link
Contributor

@yrns yrns commented Jul 15, 2024

Objective

For clips with more than one curve, only the first was being applied if there is only one keyframe in it.

Solution

Continue!

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Animation Make things move and change over time labels Jul 15, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14.1 milestone Jul 15, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jul 15, 2024
MrGVSV
MrGVSV approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about animation, but the change does look more correct to me.

IQuick143
IQuick143 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@IQuick143 IQuick143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not an animation guy, but the changes match up to the PR desc.

Would be nice if there was an unit test for this.

mweatherley
mweatherley approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'm surprised I hadn't noticed this after staring at this code for so long.

@mweatherley mweatherley added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 17, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 22, 2024
Merged via the queue into bevyengine:main with commit e06f4d4 Jul 22, 2024
32 checks passed
@yrns yrns deleted the 1-frame branch July 22, 2024 23:27
mockersf pushed a commit that referenced this pull request Aug 2, 2024
@yrns @mockersf
Fix single keyframe animations. (#14344)
2e577bc 
# Objective

For clips with more than one curve, only the first was being applied if
there is only one keyframe in it.

## Solution

Continue!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

@IQuick143 IQuick143 IQuick143 approved these changes

@mweatherley mweatherley mweatherley approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.
5 participants
@yrns @mweatherley @IQuick143 @MrGVSV @alice-i-cecile