Fix 3D Gizmo webgpu rendering #14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Aug 8, 2024
tychedelia
approved these changes
Aug 9, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
This was referenced Aug 12, 2024
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2024
# Objective - Gizmo rendering on WebGPU has been fixed by #14653, but gizmo joints still cause error (#14696 (comment)) when enabled. ## Solution - Applies the same fix as #14653 to Gizmo joints. I'm noob and just copied their solution, please correct me if I did something wrong. ## Testing - Tested 2d-gizmos and 3d-gizmos examples in WebGPU on Chrome. No rendering errors, and the gizmo joints are apparently rendered ok.
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
# Objective The changes made in #12252 introduced an previously fixed bug in webgpu rendering. ## Solution This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline. ## Testing - Tested the 3D Gizmo example in webgpu and webgl environments Co-authored-by: Alice Cecile <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Sep 5, 2024
# Objective - Gizmo rendering on WebGPU has been fixed by #14653, but gizmo joints still cause error (#14696 (comment)) when enabled. ## Solution - Applies the same fix as #14653 to Gizmo joints. I'm noob and just copied their solution, please correct me if I did something wrong. ## Testing - Tested 2d-gizmos and 3d-gizmos examples in WebGPU on Chrome. No rendering errors, and the gizmo joints are apparently rendered ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The changes made in #12252 introduced an previously fixed bug in webgpu rendering.
Solution
This fix is based on #8910 and applies the same vertex buffer layout assignment for the LineGizmo Pipeline.
Testing