Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify std::mem references #15315

Merged
merged 2 commits into from
Sep 19, 2024
Merged

simplify std::mem references #15315

merged 2 commits into from
Sep 19, 2024

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Solution

  • Remove unnecessary usings and simplify references to those functions.

Testing

CI

@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your PR increases Bevy Minimum Supported Rust Version. Please update the rust-version field in the root Cargo.toml file.

bushrat011899
bushrat011899 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely little change!

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 19, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 19, 2024
Merged via the queue into bevyengine:main with commit 1b8c1c1 Sep 19, 2024
32 checks passed
@BenjaminBrienen BenjaminBrienen deleted the simplify-std-meme branch September 19, 2024 21:50
@BenjaminBrienen BenjaminBrienen self-assigned this Nov 10, 2024
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify std:mem::{size_of, size_of_val, align_of, align_of_val}
4 participants
@BenjaminBrienen @bushrat011899 @alice-i-cecile @janhohenheim