Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix unsoundness in Query::for_each_mut #2045

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix unsoundness in Query::for_each_mut #2045

wants to merge 1 commit into from

Conversation

TheRawMeatball
Copy link
Member

No description provided.

@TheRawMeatball TheRawMeatball added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events P-High This is particularly urgent, and deserves immediate attention labels Apr 29, 2021
bjorn3
bjorn3 approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 29, 2021
@cart
Copy link
Member

cart commented Apr 29, 2021

🤦

@cart
Copy link
Member

cart commented Apr 29, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 29, 2021
@TheRawMeatball
Fix unsoundness in Query::for_each_mut (#2045)
dbf519c
@bors
Copy link
Contributor

bors bot commented Apr 29, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix unsoundness in Query::for_each_mut [Merged by Bors] - Fix unsoundness in Query::for_each_mut Apr 29, 2021
@bors bors bot closed this Apr 29, 2021
NiklasEi pushed a commit to NiklasEi/bevy that referenced this pull request May 1, 2021
@TheRawMeatball @NiklasEi
Fix unsoundness in Query::for_each_mut (bevyengine#2045)
53c1326
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@TheRawMeatball @ostwilkens
Fix unsoundness in Query::for_each_mut (bevyengine#2045)
49675a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheRawMeatball @cart @alice-i-cecile @bjorn3