[Merged by Bors] - Fixes dropping empty BlobVec #2295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
C-Bug
|
LGTM once formatted 👍 |
mockersf
approved these changes
Jun 2, 2021
|
Can you add a test where the type has |
NathanSWard
suggested changes
Jun 2, 2021
NathanSWard
suggested changes
Jun 2, 2021
Co-authored-by: Nathan Ward <[email protected]>
NathanSWard
added
the
P-High
Co-authored-by: Nathan Ward <[email protected]>
NathanSWard
approved these changes
Jun 2, 2021
NathanSWard
added
the
S-Ready-For-Final-Review
bjorn3
approved these changes
Jun 2, 2021
|
Looks good to me! Thanks for the quick fix! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
When dropping the data, we originally only checked the size of an individual item instead of the size of the allocation. However with a capacity of 0, we attempt to deallocate a pointer which was not the result of allocation. That is, an item of `Layout { size_: 8, align_: 8 }` produces an array of `Layout { size_: 0, align_: 8 }` when `capacity = 0`.
Fixes #2294
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
When dropping the data, we originally only checked the size of an individual item instead of the size of the allocation. However with a capacity of 0, we attempt to deallocate a pointer which was not the result of allocation. That is, an item of `Layout { size_: 8, align_: 8 }` produces an array of `Layout { size_: 0, align_: 8 }` when `capacity = 0`.
Fixes bevyengine#2294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dropping the data, we originally only checked the size of an individual item instead of the size of the allocation. However with a capacity of 0, we attempt to deallocate a pointer which was not the result of allocation. That is, an item of
Layout { size_: 8, align_: 8 }produces an array ofLayout { size_: 0, align_: 8 }whencapacity = 0.Fixes #2294