[Merged by Bors] - Fix unsetting RenderLayers bit in without fn #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! You should now that bevy_render is undergoing a large refactor. Even though the part you changed is not touched by it, it may be some time before this PR is merged. Is it something critical for you? |
mockersf
added
A-Rendering
|
Hi. No it's not critical. I have a workaround by just inserting a new RenderLayers component with the new mask. So no problem waiting. Thanks! |
|
I think theres a good chance that we will use this RenderLayers impl in the new renderer. I'm sold on merging this now / this looks good to me. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2021
# Objective Fixes how the layer bit is unset in the RenderLayers bit mask when calling the `without` method. ## Solution Unsets the layer bit using `&=` and the inverse of the layer bit mask.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Fixes how the layer bit is unset in the RenderLayers bit mask when calling the `without` method. ## Solution Unsets the layer bit using `&=` and the inverse of the layer bit mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes how the layer bit is unset in the RenderLayers bit mask when calling the
withoutmethod.Solution
Unsets the layer bit using
&=and the inverse of the layer bit mask.