-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Color::hex fn #362
Add Color::hex fn #362
Conversation
Does |
I haven't quite sorted out how I want to handle minimum rust versions. Maybe whatever is currently in stable ubuntu? For now, that feature is fresh enough that I think we should hold off. |
What if we had a feature flag for optimizations that are only available on later versions of Rust? It would be disabled by default, but could be enabled to take advantage of later features? |
I tried playing with it and think even with I think the feature flags for newer rust optimizations is a good idea for optional functionality, but I don't think this will be a place we can add it (sadly) |
I think in general I would prefer to keep the features as minimal as possible. We can just adopt adopt new features when they hit our MSRV (whatever that ends up being). Each code path we add introduces maintenance burden and build complexity. I'd rather just support one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just resolve merge conflicts and we're good to go!
(sorry for merging a newer pr first + creating the conflicts. i'll try to give precedence to earlier prs in the future)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency check:
- 1 new dependency:
hex
hex
's only runtime dependency is a off-by-default optionalserde
dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Add Color::hex fn
Allows to create color from hex value