-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Make many_cubes example more interesting #4015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Random cube colors would also be nice for consistency and interest, but I'm unsure if that will affect performance.
added a light so that the cubes show their true color many_cubes-light.mp4 |
bors r+ |
Merge conflict. |
@mockersf, can you rebase this when you get a chance? |
done! |
bors r+ |
# Objective - Make the many_cubes example more interesting (and look more like many_sprites) ## Solution - Actually display many cubes - Move the camera around
I hadn't seen this PR until it was merged, but I'm not sure I like this. I just ran it now, and it's quite uncomfortable to watch. I only had it on for 700 frames apparently (31 seconds), and my eyes are still 'sore' almost 5 minutes later. I'm not sure why that is, but I assume it's creating some nasty moiré patterns? |
Fair. Perhaps we can make it less uncomfortable in a follow-up PR? |
Sorry for that. I did find it a little dizzying, but that was fixed for my by adding a bigger cube to act as a reference point. Would it work to slow down the camera rotations? |
I tried slowing down the camera and adding extra space between the cubes: https://github.com/mockersf/bevy/tree/many-calm-cubes |
So I just tried that branch, and get a similar feeling, although I think it might be less bad. I think it would still be better as slower though. Unfortunately, I don't have any real suggestions for making it better :( |
We could do very basic user-control perhaps? That would make it more useful as an example, but less useful as a quasi-benchmark. |
I tried a few other things in #4117 |
# Objective - After #4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
# Objective - Make the many_cubes example more interesting (and look more like many_sprites) ## Solution - Actually display many cubes - Move the camera around
# Objective - After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
# Objective - Make the many_cubes example more interesting (and look more like many_sprites) ## Solution - Actually display many cubes - Move the camera around
# Objective - After bevyengine#4015, the `many_cubes` example could introduce discomfort in some cases ## Solution - Slow down the camera, add space between the cubes https://user-images.githubusercontent.com/8672791/156898412-0fcd29b4-63b1-4e11-bf52-7ec40cb8f932.mp4
Objective
Solution