Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Minor Bevy Logo Tweaks #4050

Closed
wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Feb 27, 2022

@BlackPhlox kindly pointed out and resolved a couple of inconsistencies in the bevy logo:

  • The arc of the first bird's back had three vertices right next to each other, which created a noticeable sharp edge. This replaces them with a single vertex.
  • The bottom part of the tail had a sharp edge, which was inconsistent with the top part of the tail. This was rounded out to mirror the top part.

I also took the chance to clean up some of the variants and (hopefully) improve the "bevy_logo_light_dark_and_dimmed" variant to improve how it renders on dark themes.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 27, 2022
@cart
Copy link
Member Author

cart commented Feb 27, 2022

If merged, we should follow up with changes in the bevy website repo.

@alice-i-cecile alice-i-cecile added A-Meta About the project itself and removed S-Needs-Triage This issue needs to be labelled labels Feb 27, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very slightly nicer. LGTM.

@cart
Copy link
Member Author

cart commented Feb 27, 2022

(I will also follow up with Bevy Merch store updates)

@cart
Copy link
Member Author

cart commented Feb 27, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 27, 2022
@BlackPhlox kindly pointed out and resolved a couple of inconsistencies in the bevy logo:
* The arc of the first bird's back had three vertices right next to each other, which created a noticeable sharp edge. This replaces them with a single vertex.
* The bottom part of the tail had a sharp edge, which was inconsistent with the top part of the tail. This was rounded out to mirror the top part.

I also took the chance to clean up some of the variants and (hopefully) improve the "bevy_logo_light_dark_and_dimmed" variant to improve how it renders on dark themes.
@bors bors bot changed the title Minor Bevy Logo Tweaks [Merged by Bors] - Minor Bevy Logo Tweaks Feb 27, 2022
@bors bors bot closed this Feb 27, 2022
kurtkuehnert pushed a commit to kurtkuehnert/bevy that referenced this pull request Mar 6, 2022
@BlackPhlox kindly pointed out and resolved a couple of inconsistencies in the bevy logo:
* The arc of the first bird's back had three vertices right next to each other, which created a noticeable sharp edge. This replaces them with a single vertex.
* The bottom part of the tail had a sharp edge, which was inconsistent with the top part of the tail. This was rounded out to mirror the top part.

I also took the chance to clean up some of the variants and (hopefully) improve the "bevy_logo_light_dark_and_dimmed" variant to improve how it renders on dark themes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants