[Merged by Bors] - insert the gltf mesh name on the entity if there is one #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
A-Assets
superdump
approved these changes
Mar 6, 2022
djee-ms
approved these changes
Mar 6, 2022
james7132
approved these changes
Mar 8, 2022
james7132
added
the
S-Ready-For-Final-Review
mockersf
force-pushed
the
gltf-name-on-mesh
branch
from
4169eb5
to
ddc7246
Compare
|
bors r+ |
|
Merge conflict. |
mockersf
force-pushed
the
gltf-name-on-mesh
branch
from
ddc7246
to
d15f5d0
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
# Objective - In glTF, mesh can be named. This named is used to be able to reference the mesh, but not as a component on the entity - Bevy only added the node name to the parent node. ## Solution - Also adds the name on the mesh entity if there is one. Limitation: In glTF, it's possible to have one mesh (which can be named) corresponding to several primitives (which can't, but are the actual mesh). I added the mesh name to the entity with the `PbrBundle` matching the primitives, which means that a mesh with several primitives would all have the same name. I think this is acceptable...
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
) # Objective - In glTF, mesh can be named. This named is used to be able to reference the mesh, but not as a component on the entity - Bevy only added the node name to the parent node. ## Solution - Also adds the name on the mesh entity if there is one. Limitation: In glTF, it's possible to have one mesh (which can be named) corresponding to several primitives (which can't, but are the actual mesh). I added the mesh name to the entity with the `PbrBundle` matching the primitives, which means that a mesh with several primitives would all have the same name. I think this is acceptable...
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
) # Objective - In glTF, mesh can be named. This named is used to be able to reference the mesh, but not as a component on the entity - Bevy only added the node name to the parent node. ## Solution - Also adds the name on the mesh entity if there is one. Limitation: In glTF, it's possible to have one mesh (which can be named) corresponding to several primitives (which can't, but are the actual mesh). I added the mesh name to the entity with the `PbrBundle` matching the primitives, which means that a mesh with several primitives would all have the same name. I think this is acceptable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Limitation: In glTF, it's possible to have one mesh (which can be named) corresponding to several primitives (which can't, but are the actual mesh). I added the mesh name to the entity with the
PbrBundlematching the primitives, which means that a mesh with several primitives would all have the same name. I think this is acceptable...