Update docs for Updated, Changed and Mutated #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I agree that the wording is a little bit clunky, but for now this is still a nice improvement. |
|
Oh I think I used the wrong ` or ' for one of these |
|
Much nicer wording. Thanks! |
|
Nice! Just not seeing an explanation related to the behavior that could be unexpected, specifically (quoting from #442 )
This may be too much to explain in comments, so maybe the book should? |
|
Hmm, that's what the "since the start of the frame" was meant to convey, but if that isn't clear enough then it's probably worth rewording, or explicitly mentioning it. |
karroffel
added
C-Docs
|
I think the current text is at the very least, a big improvement. You all are always welcome to add more docs in follow up prs 😄 |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Update docs for Updated, Changed and Mutated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording feels a bit clunky to me but I can't think of a better way to write this.
Resolves #442