[Merged by Bors] - Disable Vsync for stress tests. #5187
Conversation
|
I think you should add Also, while I don't necessarily disagree with the idea, on g-sync monitors the framerate will still be capped to the refresh rate while the app is windowed and focused. |
alice-i-cecile
added
A-Rendering
|
I'm of the same opinion as @IceSentry above :) Clean that up and I'd be fully on board. We should consider refactoring these examples to reduce duplication, but that's a different PR. |
Done
Unless something has changed in the past ~1.5 years, I don't think enabling Gsync caps your framerate? I know freesync doesn't currently cap your framerate. |
|
It caps it, but only when the window is not full screen and in focus. It's just not noticeable for most people because most people play games in fullscreen. I've confirmed this with multiple people including some people working on wgpu. It's a weird edge case, but it definitely happens. |
|
Should we full screen the stress tests by default then? |
|
No, I really don't think it matters that much and I'd rather not have some examples going fullscreen when developing. I was just pointing it out because it was really weird when I discovered it. You can easily push the tests to go bellow the refresh rate anyway. Most people don't have a g-sync monitor anyway so it's very much an edge case and it's easy to bypass, just don't focus the window while the test is running or put it on another monitor. (Yes, I know not everyone has a second monitor, but people with g-sync monitors are already a minority and I wouldn't be surprised if most of those people also have a second monitor) |
|
I guess this never came up because most of us are below async rates on those examples anyway 😄 |
mockersf
added
the
S-Ready-For-Final-Review
# Objective Currently stress tests are vsynced. This is undesirable for a stress test, as you want to run them with uncapped framerates. ## Solution Ensure all stress tests are using PresentMode::Immediate if they render anything.
bors
bot
changed the title
# Objective Currently stress tests are vsynced. This is undesirable for a stress test, as you want to run them with uncapped framerates. ## Solution Ensure all stress tests are using PresentMode::Immediate if they render anything.
# Objective Currently stress tests are vsynced. This is undesirable for a stress test, as you want to run them with uncapped framerates. ## Solution Ensure all stress tests are using PresentMode::Immediate if they render anything.
# Objective Currently stress tests are vsynced. This is undesirable for a stress test, as you want to run them with uncapped framerates. ## Solution Ensure all stress tests are using PresentMode::Immediate if they render anything.
Objective
Currently stress tests are vsynced. This is undesirable for a stress test, as you want to run them with uncapped framerates.
Solution
Ensure all stress tests are using PresentMode::Immediate if they render anything.