[Merged by Bors] - Expose Image conversion functions (fixes #5452)
#5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
|
|
Is this still WIP? I see commented code and builds fail. Makes sense I think. There is a few more image formats that can be supported, I've a branch of bevy that adds four more compatible image formats. I'll upload them later and let you copy the code. The idea of exposing the |
|
Sorry about the messiness, I'm a hobbyist and it's the first time I've ever tried submitting code to a public repo. I tried implementing |
micron-mushroom
force-pushed
the
main
branch
2 times, most recently
from
cdff730
to
fd41f5b
Compare
|
I'll try the changes with some code that would benefit from this change and drop a review tomorrow. |
nicopap
suggested changes
Aug 2, 2022
nicopap
approved these changes
Aug 2, 2022
IceSentry
reviewed
Aug 3, 2022
|
@IceSentry is it good to merge now? |
IceSentry
approved these changes
Aug 4, 2022
IceSentry
added
the
M-Needs-Migration-Guide
|
🤔 actually, the old function was pub(crate) so I guess it isn't a breaking change |
IceSentry
removed
the
M-Needs-Migration-Guide
rparrett
added
the
S-Ready-For-Final-Review
|
Change makes sense to me, and is well-documented and has basic tests. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
## Solution Exposes the image <-> "texture" as methods on `Image`. ## Extra I'm wondering if `image_texture_conversion.rs` should be renamed to `image_conversion.rs`. That or the file be deleted altogether in favour of putting the code alongside the rest of the `Image` impl. Its kind-of weird to refer to the `Image` as a texture. Also `Image::convert` is a public method so I didn't want to edit its signature, but it might be nice to have the function consume the image instead of just passing a reference to it because it would eliminate a clone. ## Changelog > Rename `image_to_texture` to `Image::from_dynamic` > Rename `texture_to_image` to `Image::try_into_dynamic` > `Image::try_into_dynamic` now returns a `Result` (this is to make it easier for users who didn't read that only a few conversions are supported to figure it out.)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Image conversion functions (fixes #5452)Image conversion functions (fixes #5452)
ickk
added
the
M-Needs-Migration-Guide
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ne#5527) ## Solution Exposes the image <-> "texture" as methods on `Image`. ## Extra I'm wondering if `image_texture_conversion.rs` should be renamed to `image_conversion.rs`. That or the file be deleted altogether in favour of putting the code alongside the rest of the `Image` impl. Its kind-of weird to refer to the `Image` as a texture. Also `Image::convert` is a public method so I didn't want to edit its signature, but it might be nice to have the function consume the image instead of just passing a reference to it because it would eliminate a clone. ## Changelog > Rename `image_to_texture` to `Image::from_dynamic` > Rename `texture_to_image` to `Image::try_into_dynamic` > `Image::try_into_dynamic` now returns a `Result` (this is to make it easier for users who didn't read that only a few conversions are supported to figure it out.)
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ne#5527) ## Solution Exposes the image <-> "texture" as methods on `Image`. ## Extra I'm wondering if `image_texture_conversion.rs` should be renamed to `image_conversion.rs`. That or the file be deleted altogether in favour of putting the code alongside the rest of the `Image` impl. Its kind-of weird to refer to the `Image` as a texture. Also `Image::convert` is a public method so I didn't want to edit its signature, but it might be nice to have the function consume the image instead of just passing a reference to it because it would eliminate a clone. ## Changelog > Rename `image_to_texture` to `Image::from_dynamic` > Rename `texture_to_image` to `Image::try_into_dynamic` > `Image::try_into_dynamic` now returns a `Result` (this is to make it easier for users who didn't read that only a few conversions are supported to figure it out.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Exposes the image <-> "texture" as methods on
Image.Extra
I'm wondering if
image_texture_conversion.rsshould be renamed toimage_conversion.rs. That or the file be deleted altogether in favour of putting the code alongside the rest of theImageimpl. Its kind-of weird to refer to theImageas a texture.Also
Image::convertis a public method so I didn't want to edit its signature, but it might be nice to have the function consume the image instead of just passing a reference to it because it would eliminate a clone.Changelog