[Merged by Bors] - Add warning when using load_folder on web #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Aug 29, 2022
mockersf
added
A-Assets
IceSentry
reviewed
Aug 29, 2022
| @@ -52,6 +52,7 @@ impl AssetIo for WasmAssetIo { | |||
| &self, | |||
| _path: &Path, | |||
| ) -> Result<Box<dyn Iterator<Item = PathBuf>>, AssetIoError> { | |||
| bevy_log::warn!("Loading folders is not supported in WASM"); | |||
There was a problem hiding this comment.
To keep in line with the name of the method
Suggested change
| bevy_log::warn!("Loading folders is not supported in WASM"); | |
| bevy_log::warn!("Reading a directory is not supported in WASM"); |
There was a problem hiding this comment.
I thought that this phrasing would be more useful to normal users who would see this message when attempting to use load_folder.
There was a problem hiding this comment.
Right, I guess that makes sense then since it's probably going to be the more common use case
IceSentry
approved these changes
Aug 29, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 29, 2022
# Objective Help users who are using `load_folder` in wasm builds to find a slightly shorter path to figuring out why their stuff is broken. ## Solution Adds a warning to `read_directory` in the `WasmAssetIo`. This is extremely similar to the warning already emitted a few lines below for `watch_for_changes`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Help users who are using `load_folder` in wasm builds to find a slightly shorter path to figuring out why their stuff is broken. ## Solution Adds a warning to `read_directory` in the `WasmAssetIo`. This is extremely similar to the warning already emitted a few lines below for `watch_for_changes`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Help users who are using `load_folder` in wasm builds to find a slightly shorter path to figuring out why their stuff is broken. ## Solution Adds a warning to `read_directory` in the `WasmAssetIo`. This is extremely similar to the warning already emitted a few lines below for `watch_for_changes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Help users who are using
load_folderin wasm builds to find a slightly shorter path to figuring out why their stuff is broken.Solution
Adds a warning to
read_directoryin theWasmAssetIo.This is extremely similar to the warning already emitted a few lines below for
watch_for_changes.