[Merged by Bors] - Remove unnecessary unsafe Send and Sync impl for WinitWindows on wasm.
#5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like these were made redundant with #4027 |
mockersf
approved these changes
Sep 2, 2022
mockersf
added
A-Windowing
|
bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
…n wasm. (#5863) # Objective #503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Send and Sync impl for WinitWindows on wasm.Send and Sync impl for WinitWindows on wasm.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…n wasm. (bevyengine#5863) # Objective bevyengine#503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…n wasm. (bevyengine#5863) # Objective bevyengine#503 added these. I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me. ## Solution AFAIK removing unsafe `Send`/`Sync` impls can't introduce unsoundness. Yeet. ## Migration Guide Why tho. Co-authored-by: devil-ira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#503 added these.
I don't know what problem it solved, the PR doesn't say and the code didn't make it obvious to me.
Solution
AFAIK removing unsafe
Send/Syncimpls can't introduce unsoundness.Yeet.
Migration Guide
Why tho.