Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Scene example: write file in a task #5952

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Scene example: write file in a task #5952

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03cb426
write file in a task
mockersf Sep 11, 2022
98f104e
comment not true anymore
mockersf Sep 11, 2022
cf6b9bf
this map_err is not needed either
mockersf Sep 11, 2022
a7b05c5
do not write file in wasm
mockersf Sep 11, 2022
1ed1ed6
english
mockersf Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions examples/scene/scene.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
use std::fs::File;
use std::io::Write;

use bevy::{prelude::*, utils::Duration};
use bevy::{prelude::*, tasks::IoTaskPool, utils::Duration};

fn main() {
App::new()
Expand Down Expand Up @@ -104,17 +104,23 @@ fn save_scene_system(world: &mut World) {
let scene = DynamicScene::from_world(&scene_world, type_registry);

// Scenes can be serialized like this:
info!("{}", scene.serialize_ron(type_registry).unwrap());

// Write the scene RON data to file (leveraging From<io::Error> for ron::error::Error)
File::create(format!("assets/{}", NEW_SCENE_FILE_PATH))
.map_err(|err| err.into())
.and_then(|mut file| {
scene
.serialize_ron(type_registry)
.and_then(|data| file.write(data.as_bytes()).map_err(|err| err.into()))
let serialized_scene = scene.serialize_ron(type_registry).unwrap();

// Showing the scene in the console
info!("{}", serialized_scene);

// Writing the scene to a new file. Using a task to avoid calling the filesystem APIs in a system
// as they are blocking
// This can't work in WASM as there is no filesystem access
#[cfg(not(target_arch = "wasm32"))]
IoTaskPool::get()
.spawn(async move {
// Write the scene RON data to file
File::create(format!("assets/{}", NEW_SCENE_FILE_PATH))
.and_then(|mut file| file.write(serialized_scene.as_bytes()))
.expect("Error while writing scene to file");
})
.expect("Error while writing scene to file");
.detach();
}

// This is only necessary for the info message in the UI. See examples/ui/text.rs for a standalone
Expand Down