[Merged by Bors] - Derive Reflect + FromReflect for window event types
#6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TehPers
changed the title
Reflect + FromReflect on window typesReflect + FromReflect for window types
TehPers
changed the title
Reflect + FromReflect for window typesReflect + FromReflect for window event types
MrGVSV
added
A-Windowing
MrGVSV
reviewed
Oct 11, 2022
`bevy_window` already depends on `glam` transitively, this just imports the reflection impls.
|
Edit: changes are merged now |
MrGVSV
approved these changes
Oct 19, 2022
mockersf
reviewed
Oct 19, 2022
|
@TehPers Could you rebase this PR? |
|
@TehPers looks like there's been some more conflicts added. Could you rebase? I'm hoping we can actually try to get this in soon so it's not just sitting around increasing in conflicts for you to resolve 😅 |
cart
approved these changes
Dec 9, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
# Objective The window event types currently don't support reflection. This PR adds support to them (as requested [here](#6223 (comment))). ## Solution Implement `Reflect` + `FromReflect` for window event types. Relevant traits are also being reflected with `#[reflect(...)]` attributes. Additionally, this PR derives `Reflect` + `FromReflect` for `WindowDescriptor` and the types it depends on so that `CreateWindow` events can be fully manipulated through reflection. Finally, this PR adds `FromReflect` for `PathBuf` as a value type, which is needed for `FileDragAndDrop`. This adds the "glam" feature to the `bevy_reflect` dependency for package `bevy_window`. Since `bevy_window` transitively depends on `glam` already, all this brings in are the reflection `impl`s. ## Open questions Should `app.register_type::<PathBuf>();` be moved to `CorePlugin`? I added it to `WindowPlugin` because that's where it's used and `CorePlugin` doesn't seem to register all the missing std types, but it would also make sense in `CorePlugin` I believe since it's a commonly used type. --- ## Changelog Added: - Implemented `Reflect` + `FromReflect` for window events and related types. These types are automatically registered when adding the `WindowPlugin`.
bors
bot
changed the title
Reflect + FromReflect for window event typesReflect + FromReflect for window event types
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
) # Objective The window event types currently don't support reflection. This PR adds support to them (as requested [here](bevyengine#6223 (comment))). ## Solution Implement `Reflect` + `FromReflect` for window event types. Relevant traits are also being reflected with `#[reflect(...)]` attributes. Additionally, this PR derives `Reflect` + `FromReflect` for `WindowDescriptor` and the types it depends on so that `CreateWindow` events can be fully manipulated through reflection. Finally, this PR adds `FromReflect` for `PathBuf` as a value type, which is needed for `FileDragAndDrop`. This adds the "glam" feature to the `bevy_reflect` dependency for package `bevy_window`. Since `bevy_window` transitively depends on `glam` already, all this brings in are the reflection `impl`s. ## Open questions Should `app.register_type::<PathBuf>();` be moved to `CorePlugin`? I added it to `WindowPlugin` because that's where it's used and `CorePlugin` doesn't seem to register all the missing std types, but it would also make sense in `CorePlugin` I believe since it's a commonly used type. --- ## Changelog Added: - Implemented `Reflect` + `FromReflect` for window events and related types. These types are automatically registered when adding the `WindowPlugin`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
) # Objective The window event types currently don't support reflection. This PR adds support to them (as requested [here](bevyengine#6223 (comment))). ## Solution Implement `Reflect` + `FromReflect` for window event types. Relevant traits are also being reflected with `#[reflect(...)]` attributes. Additionally, this PR derives `Reflect` + `FromReflect` for `WindowDescriptor` and the types it depends on so that `CreateWindow` events can be fully manipulated through reflection. Finally, this PR adds `FromReflect` for `PathBuf` as a value type, which is needed for `FileDragAndDrop`. This adds the "glam" feature to the `bevy_reflect` dependency for package `bevy_window`. Since `bevy_window` transitively depends on `glam` already, all this brings in are the reflection `impl`s. ## Open questions Should `app.register_type::<PathBuf>();` be moved to `CorePlugin`? I added it to `WindowPlugin` because that's where it's used and `CorePlugin` doesn't seem to register all the missing std types, but it would also make sense in `CorePlugin` I believe since it's a commonly used type. --- ## Changelog Added: - Implemented `Reflect` + `FromReflect` for window events and related types. These types are automatically registered when adding the `WindowPlugin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The window event types currently don't support reflection. This PR adds support to them (as requested here).
Solution
Implement
Reflect+FromReflectfor window event types. Relevant traits are also being reflected with#[reflect(...)]attributes.Additionally, this PR derives
Reflect+FromReflectforWindowDescriptorand the types it depends on so thatCreateWindowevents can be fully manipulated through reflection.Finally, this PR adds
FromReflectforPathBufas a value type, which is needed forFileDragAndDrop.This adds the "glam" feature to the
bevy_reflectdependency for packagebevy_window. Sincebevy_windowtransitively depends onglamalready, all this brings in are the reflectionimpls.Open questions
Should
app.register_type::<PathBuf>();be moved toCorePlugin? I added it toWindowPluginbecause that's where it's used andCorePlugindoesn't seem to register all the missing std types, but it would also make sense inCorePluginI believe since it's a commonly used type.Changelog
Added:
Reflect+FromReflectfor window events and related types. These types are automatically registered when adding theWindowPlugin.