Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove outdated uses of single-tuple bundles #6406

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Remove outdated uses of single-tuple bundles #6406

wants to merge 3 commits into from

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Oct 29, 2022

Objective

Bevy still has many instances of using single-tuples (T,) to create a bundle. Due to #2975, this is no longer necessary.

Solution

Search for regex \(.+\s*,\). This should have found every instance.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 29, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 29, 2022
@JoJoJet
Remove outdated uses of single-tuple bundles (#6406)
336049d 
# Objective

Bevy still has many instances of using single-tuples `(T,)` to create a bundle. Due to #2975, this is no longer necessary.

## Solution

Search for regex `\(.+\s*,\)`. This should have found every instance.
@JoJoJet
Copy link
Member Author

JoJoJet commented Oct 29, 2022

Well that was fast

@bors
Copy link
Contributor

bors bot commented Oct 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove outdated uses of single-tuple bundles [Merged by Bors] - Remove outdated uses of single-tuple bundles Oct 29, 2022
@bors bors bot closed this Oct 29, 2022
@JoJoJet JoJoJet deleted the single-tuple branch December 1, 2022 15:05
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@JoJoJet @ItsDoot
Remove outdated uses of single-tuple bundles (bevyengine#6406)
aa178e9 
# Objective

Bevy still has many instances of using single-tuples `(T,)` to create a bundle. Due to bevyengine#2975, this is no longer necessary.

## Solution

Search for regex `\(.+\s*,\)`. This should have found every instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoJoJet @alice-i-cecile @tim-blackbird @mockersf