Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add reflect_owned #6494

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Add reflect_owned #6494

wants to merge 2 commits into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 6, 2022

Objective

There is no way to gen an owned value of Reflect.

Solution

Add it! This was originally a part of #6421, but @MrGVSV asked me to create a separate for it to implement reflect diffing.

Changelog

Added

  • Reflect::reflect_owned to get an owned version of Reflect.

@Shatur Shatur requested a review from MrGVSV November 6, 2022 10:07
@Weibye Weibye added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Nov 6, 2022
MrGVSV
MrGVSV approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for completing the set! 😄

Just one typo correction.

crates/bevy_reflect/src/reflect.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 6, 2022
@Shatur @MrGVSV
Fix typo
b9e61b9 
Co-authored-by: Gino Valente <[email protected]>
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 6, 2022
@Shatur
Add reflect_owned (#6494)
feebbc5 
# Objective

There is no way to gen an owned value of `Reflect`.

## Solution

Add it! This was originally a part of #6421, but @MrGVSV asked me to create a separate for it to implement reflect diffing.

---

## Changelog

### Added

- `Reflect::reflect_owned` to get an owned version of `Reflect`.
@bors
Copy link
Contributor

bors bot commented Nov 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add reflect_owned [Merged by Bors] - Add reflect_owned Nov 6, 2022
@bors bors bot closed this Nov 6, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@Shatur @ItsDoot
Add reflect_owned (bevyengine#6494)
61f0271 
# Objective

There is no way to gen an owned value of `Reflect`.

## Solution

Add it! This was originally a part of bevyengine#6421, but @MrGVSV asked me to create a separate for it to implement reflect diffing.

---

## Changelog

### Added

- `Reflect::reflect_owned` to get an owned version of `Reflect`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Reflection
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shatur @alice-i-cecile @MrGVSV @Weibye