Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add send_event and friends to WorldCell #6515

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add send_event and friends to WorldCell #6515

wants to merge 1 commit into from

Conversation

tim-blackbird
Copy link
Contributor

Objective

Copy send_event and friends from World to WorldCell.

Clean up bevy_winit using WorldCell::send_event.

Changelog

Added send_event, send_event_default, and send_event_batch to WorldCell.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 7, 2022
@alice-i-cecile
Copy link
Member

Slowly untangling that code is very nice, thank you.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 7, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 7, 2022
@tim-blackbird
Add send_event and friends to WorldCell (#6515)
d688ba5 
# Objective

Copy `send_event` and friends from `World` to `WorldCell`.

Clean up `bevy_winit` using `WorldCell::send_event`.

## Changelog

Added `send_event`, `send_event_default`, and `send_event_batch` to `WorldCell`.

Co-authored-by: devil-ira <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add send_event and friends to WorldCell [Merged by Bors] - Add send_event and friends to WorldCell Nov 7, 2022
@bors bors bot closed this Nov 7, 2022
@tim-blackbird tim-blackbird deleted the worldcell-send-event branch November 7, 2022 21:58
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tim-blackbird @ItsDoot
Add send_event and friends to WorldCell (bevyengine#6515)
e84dbda 
# Objective

Copy `send_event` and friends from `World` to `WorldCell`.

Clean up `bevy_winit` using `WorldCell::send_event`.

## Changelog

Added `send_event`, `send_event_default`, and `send_event_batch` to `WorldCell`.

Co-authored-by: devil-ira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tim-blackbird @alice-i-cecile @james7132