Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_scene: Add missing registration for SmallVec<[Entity; 8]> #6578

Closed
wants to merge 1 commit into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Nov 13, 2022

Objective

Part of #6573

Children was not being properly deserialized in scenes. This was due to a missing registration on SmallVec<[Entity; 8]>, which is used by Children.

Solution

Register SmallVec<[Entity; 8]>.


Changelog

  • Registered SmallVec<[Entity; 8]>

@MrGVSV MrGVSV added C-Bug An unexpected or incorrect behavior A-Scenes Serialized ECS data stored on the disk labels Nov 13, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 13, 2022
@MrGVSV MrGVSV added this to the 0.9.1 milestone Nov 13, 2022
@cart
Copy link
Member

cart commented Nov 14, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 14, 2022
# Objective

> Part of #6573

`Children` was not being properly deserialized in scenes. This was due to a missing registration on `SmallVec<[Entity; 8]>`, which is used by `Children`.

## Solution

Register `SmallVec<[Entity; 8]>`.

---

## Changelog

- Registered `SmallVec<[Entity; 8]>`
@bors bors bot changed the title bevy_scene: Add missing registration for SmallVec<[Entity; 8]> [Merged by Bors] - bevy_scene: Add missing registration for SmallVec<[Entity; 8]> Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
cart pushed a commit that referenced this pull request Nov 30, 2022
# Objective

> Part of #6573

`Children` was not being properly deserialized in scenes. This was due to a missing registration on `SmallVec<[Entity; 8]>`, which is used by `Children`.

## Solution

Register `SmallVec<[Entity; 8]>`.

---

## Changelog

- Registered `SmallVec<[Entity; 8]>`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…yengine#6578)

# Objective

> Part of bevyengine#6573

`Children` was not being properly deserialized in scenes. This was due to a missing registration on `SmallVec<[Entity; 8]>`, which is used by `Children`.

## Solution

Register `SmallVec<[Entity; 8]>`.

---

## Changelog

- Registered `SmallVec<[Entity; 8]>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Scenes Serialized ECS data stored on the disk C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants