Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - ShaderDefVal: add an UInt option #6881

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - ShaderDefVal: add an UInt option #6881

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 7, 2022

Objective

Solution

  • Add an option to have a u32 in a ShaderDefVal

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Dec 7, 2022
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 7, 2022
@mockersf
Copy link
Member Author

mockersf commented Dec 7, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 7, 2022
@mockersf
ShaderDefVal: add an UInt option (#6881)
8eedc8f 
# Objective

- Fixes #6841 
- In some case, the number of maximum storage buffers is `u32::MAX` which doesn't fit in a `i32`

## Solution

- Add an option to have a `u32` in a `ShaderDefVal`
@bors
Copy link
Contributor

bors bot commented Dec 7, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title ShaderDefVal: add an UInt option [Merged by Bors] - ShaderDefVal: add an UInt option Dec 7, 2022
@bors bors bot closed this Dec 7, 2022
@james7132 james7132 added this to the 0.10 milestone Dec 8, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
ShaderDefVal: add an UInt option (bevyengine#6881)
87b2b12 
# Objective

- Fixes bevyengine#6841 
- In some case, the number of maximum storage buffers is `u32::MAX` which doesn't fit in a `i32`

## Solution

- Add an option to have a `u32` in a `ShaderDefVal`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
ShaderDefVal: add an UInt option (bevyengine#6881)
75b4ae0 
# Objective

- Fixes bevyengine#6841 
- In some case, the number of maximum storage buffers is `u32::MAX` which doesn't fit in a `i32`

## Solution

- Add an option to have a `u32` in a `ShaderDefVal`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@IceSentry IceSentry IceSentry approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Running load_gltf example on integrated gpu panics.
4 participants
@mockersf @james7132 @IceSentry @tim-blackbird